Invalid config schema

Open on Drupal.org →

Created on 26 January 2024, 10 months ago

Updated 9 February 2024, 9 months ago

Problem/Motivation

Selection criteria is missing config schema and admin_dialogs.settings is using integers instead of booleans.

→

Steps to reproduce

Install the admin dialogs module
Install the Configuration Inspector → module.
Login as admin
View Configuration inspector report (/admin/reports/config-inspector)

Proposed resolution

Update admin_dialogs.schema.yml to define selection criteria.

Notes

Adding very basic test coverage would automatically validate the config schema.
@see https://www.drupal.org/node/2391795 →

Remaining tasks

Review MR
Merge MR

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States jrockowitz Brooklyn, NY

Live updates comments and jobs are added and updated live.

Merge Requests

!4Invalid config schema
Merged
🇺🇸United States jrockowitz
updated 10 months ago

Comments & Activities

Issue created by @jrockowitz
Comment 10 months ago →
🇺🇸United States jrockowitz Brooklyn, NY
Merge request !41.0.x → (Merged) created by jrockowitz
Status changed to Needs review 10 months ago12:17pm 26 January 2024
Comment 10 months ago →
🇺🇸United States jrockowitz Brooklyn, NY
Comment 10 months ago →
🇺🇸United States jrockowitz Brooklyn, NY
Status changed to Fixed 10 months ago12:32pm 26 January 2024
Comment 10 months ago →
🇺🇸United States minnur San Francisco
Thanks for the patch!
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024