Contrib.social

Field Group id and classes get ignored

Open on Drupal.org →
Created on 25 January 2024, about 1 year ago

Problem/Motivation

Field Group provides a form on FieldGroupFormatterBase::settingsForm that allows users to enter an ID and Classes, which is present both at the moment of the creation of the field group and when editing it.
However for SDC, only props, slots and metadata end up in Twig, so the user can enter whatever they want on the ID and classes field, but it is ignored.

Remaining tasks

Either disallow these textfields on SingleDirectoryComponent or include them as slots.

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇪🇸Spain pcambra Asturies

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @pcambra
  • Comment about 1 year ago →
    🇪🇸Spain pcambra Asturies

    Not sure what would be best, my workaround for the time being is to add the classes as a prop but feels we should integrate them directly

  • Comment about 1 year ago →
    e0ipso Can Picafort

    How do you think we should handle this? The main challenge I see with supporting the feature is that we don't necessarily have a top level element in all possible components. Should we enforce a top level HTML element for this? Or should we remove the settings?

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    e0ipso Can Picafort
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024