Util::removeHtmlComments can return both string and MarkupInterface

Open on Drupal.org →

Created on 25 January 2024, 5 months ago

Updated 8 February 2024, 5 months ago

Problem/Motivation

When an empty string is passed through Util::removeHtmlComments, MarkupInterface::create will return an empty string and not a MarkupInterface instance

TypeError: Drupal\sdc_display\Util::removeHtmlComments(): Return value must be of type Drupal\Component\Render\MarkupInterface, string returned in Drupal\sdc_display\Util::removeHtmlComments() (line 63 of modules/contrib/sdc_display/src/Util.php).

Proposed resolution

Fix the method signature and comments to reflect the right returns.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain pcambra Spain, 🇪🇺

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!10Util::removeHtmlComments can return both string and MarkupInterface
Merged
🇪🇸Spain pcambra
updated 5 months ago

Comments & Activities

Issue created by @pcambra
Comment 5 months ago →
🇪🇸Spain pcambra Spain, 🇪🇺
Merge request !10Issue #3416997: Util::removeHtmlComments can return both string and MarkupInterface → (Merged) created by pcambra
Status changed to Needs review 5 months ago3:20pm 25 January 2024
Comment 5 months ago →
🇪🇸Spain pcambra Spain, 🇪🇺
Pipeline finished with Success
5 months ago
#82398
Pipeline finished with Skipped
5 months ago
#82434
First commit to issue fork.

Comment 5 months ago →

pcambra → committed 9c3253ae on 1.x

Issue #3416997: Util::removeHtmlComments can return both string and...

Status changed to Fixed 5 months ago5:30pm 25 January 2024
Comment 5 months ago →
e0ipso Can Picafort
Thank you Pedro for the MR. This was merged now, and I will release it in a couple minutes.
Comment 5 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024