- Issue created by @tedbow
- First commit to issue fork.
- 🇺🇸United States phenaproxima Massachusetts
phenaproxima → changed the visibility of the branch 3416768-make-phptufvalidator-able to hidden.
- 🇺🇸United States phenaproxima Massachusetts
phenaproxima → changed the visibility of the branch 3416768-make-phptufvalidator-able to active.
- Assigned to tedbow
- Status changed to Needs review
6 months ago 4:18am 29 January 2024 - Assigned to phenaproxima
- Status changed to Needs work
6 months ago 8:50pm 29 January 2024 - Status changed to Needs review
6 months ago 8:57pm 29 January 2024 - 🇺🇸United States tedbow Ithaca, NY, USA
This looks good to me if the tests pass and we remove CI_DEBUG_SERVICES
- Issue was unassigned.
- Status changed to RTBC
6 months ago 9:08pm 29 January 2024 - 🇺🇸United States phenaproxima Massachusetts
Let's not remove CI_DEBUG_SERVICES. Until 🐛 Investigate random failures in nightwatch and phpunit Needs work is fixed, it increases our chances of catching a failure, and helping the actual cause of the problem get discovered. I've left a todo to remove it.
Preemptively RTBCing on the assumption that tests will pass, but would like your sign-off before I merge it.
-
phenaproxima →
committed b0222f84 on 3.0.x
Issue #3416768: For testing purposes, allow PhpTufValidator to validate...
-
phenaproxima →
committed b0222f84 on 3.0.x
- Status changed to Fixed
6 months ago 11:15pm 29 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.