- Issue created by @rcodina
- 🇺🇸United States fathershawn New York
Thank you for your contribution with code! This is a good idea. I've made a review in the MR with requested improvements to the code.
- Status changed to Needs work
11 months ago 12:49pm 26 January 2024 - last update
11 months ago 4 fail - last update
11 months ago 1 pass, 2 fail - last update
11 months ago 1 pass, 2 fail - last update
11 months ago 1 pass, 2 fail - Status changed to Needs review
11 months ago 7:10pm 5 February 2024 - 🇺🇸United States fathershawn New York
Thanks for all the revised code. I'll review as soon as I can. I haven't moved this project to GitLab CI testing yet, so in the meantime it would be good to investigate why there are test failures showing for Drupal CI?
- Status changed to Needs work
10 months ago 11:46am 22 February 2024 - 🇺🇸United States fathershawn New York
Tests passing, but 2 style issues. We still need to resolve the added module dependencies
FILE: ...lds/project/formassembly/web/modules/custom/formassembly/src/ApiMarkup.php -------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------- 166 | WARNING | [x] A comma should follow the last multiline array item. | | Found: ) (Drupal.Arrays.Array.CommaLastItem) 173 | ERROR | [x] Concat operator must be surrounded by a single space | | (Squiz.Strings.ConcatenationSpacing.PaddingFound)
- Status changed to Needs review
10 months ago 4:23pm 23 February 2024