document & refactor StaticCache::filterUncachedPaths()

Created on 24 January 2024, 5 months ago

Updated 28 January 2024, 5 months ago

This method is really confusing, and both it and the class need documentation.

The code could do with a few small refactoring tweaks to make it easier to understand:

- avoid the double-negative of a variable called $skip
- move the file_exists() check to a separate check which also can set $skip

📌 Task

Status

RTBC

Version

1.0

Component

Tome Static

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.

Merge Requests

Issue created by @joachim
Comment 5 months ago →
🇬🇧United Kingdom joachim
Merge request !16Resolve #3416742 "Document refactor filteruncachedpaths" → (Open) created by joachim
Status changed to Needs review 5 months ago3:07pm 24 January 2024
Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 5 months ago
Waiting for branch to pass
Status changed to RTBC 5 months ago9:04pm 28 January 2024
Comment 5 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Looks good to me

Production build 0.69.0 2024