Typos in two files

Created on 24 January 2024, 10 months ago
Updated 8 February 2024, 10 months ago

Problem/Motivation

There are two minor typos in /modules/content/src/Topic/TopicBase.php ("when it get" should be "when it gets") and an unnecessary word ("anymore") in /modules/content/src/Plugin/Danse/ContentSettingsTrait.php. The pedant in me feels compelled to offer a patch.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

2.3

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States rclemings

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @rclemings
  • Issue was unassigned.
  • πŸ‡ΊπŸ‡ΈUnited States rclemings
  • Status changed to Needs work 10 months ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    Thank you very much @rclemings for your contribution. Would you mind turning this into an issue fork with an MR? Patches are going away soon(ish) and MRs are using the new test infrastructure as well. Collaboration will be so much easier overall.

  • Merge request !12Resolve #3416614 "Typos in two" β†’ (Merged) created by rclemings
  • Pipeline finished with Success
    10 months ago
    #82145
  • πŸ‡ΊπŸ‡ΈUnited States rclemings

    Done, I think. Let me know if anything is wrong. First time doing it this way.

    Actually I think "gets" could be changed to "is" to save a couple of characters. I'm probably going to make that change and a few others on my site, but I'll save them for another issue, because they may not suit everybody.

  • Status changed to RTBC 10 months ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    This is great, thanks @rclemings - and it is all in perfect shape. Once an MR is being created and you want the maintainer to review your proposed changes, the status of the issue should be changed to "Needs review".

    I've just looked into it and it can be merged, so I'm setting this to RTBC.

  • Status changed to Fixed 10 months ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    Now merged your MR and setting the issue to fixed. Thank you very much for your contribution.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024