- Issue created by @Grevil
- 🇩🇪Germany Grevil
If we are at it (and have enough) time, we could look into incorporating Floating UI in our "rewritten" off-canvas code. As already mentioned in ✨ Research Popover API usage (for non-modal?) dialogs. Active
Currently, if we are using any module, which has a dependency to the core "drupal.dialog.off_canvas" library (e.g. "layout_builder"), the output breaks, and an error gets displayed in the console:
An error occurred during the execution of the Ajax response: TypeError: $element.dialog is not a function
This happens, because "drupal.dialog.off_canvas" uses Drupal.dialog SOMEWHERE in their code. I only could find calls using the jquery-ui library:
line 305-307:
getContainer($element) {
return $element.dialog('widget');
},
and line 247-249
$element
.dialog('option', adjustedOptions)
.trigger('dialogContentResize.off-canvas');
But these are just plain jquery .dialogs call.
Create an adapter library for the drupal.dialog.off_canvas
Active
1.0
Code
If we are at it (and have enough) time, we could look into incorporating Floating UI in our "rewritten" off-canvas code. As already mentioned in ✨ Research Popover API usage (for non-modal?) dialogs. Active