Variant change disables added to cart message

Interesting... Thanks for reporting.
You are operating the add-to-cart form in a pop-up. Can you reproduce it without the pop-up, simply on the product display page?

If you would, please try the patch from this issue 🐛 Message and Open commands are called despite errors in the form. Needs review , and see if it helps.

@tonytheferg - Yes. Later in the demo video I open as a node display and replicate the same.

Would it assist if I uploaded the composer file too?

No - I added the following patch with no change.

"patches":{
"patches": {
"commerce_ajax_atc": {
"Product Variable change repair": " https://www.drupal.org/files/issues/2022-02-11/3263913-2.patch → " }
}
},

and still after editing the variable of commerce product no added to cart message. Also if you add to cart the first variable that loads, yes message appears but the say you also purchasing a different size or colour of the same product. No message appears thereafter.

I would need to set up an environment with attributes. I don't actually use them in the project that motivated the writing of this module. Really, this should be fixed and test coverage added.

Maybe I can find a fix from one of the other Ajax modules once I set up an environment. Not sure when I would be able to get to that, but I would be glad to review a patch in the meantime.

Does this only affect the non modal message?

Does it work as expected with the modal pop up?

Play around with this patch a little bit and see if this helps. Going to need more work. I am noticing that the message doesn't "ajaxify" until a selection has been made.

The last submitted patch, 8: 3415762-8.patch, failed testing. View results →

yeah, I thought it might not work for vado. That's an easy fix.

The last submitted patch, 11: 3415762-10.patch, failed testing. View results →

I have tested with this patch replacing the other. It appears any time there is variable insert from the url I.E "/product/66?v=324" being the "?v=324" then no add to cart notification shows. I did read a post about ajax being "stolen" on forms (maybe commerce product variable form). https://www.drupal.org/project/commerce/issues/2916671 🐛 Ajax Paging in Views breaks Add to Cart form Needs work

I have in the interim still installed the module as it allows the cart display module to update while keeping the current page and display of product be it in colorbox or on node display.

Test with views out of the equation, and lightbox out of the equation.

Just test from the product display please.

reroll against dev.

re-reroll. disregard #15

The last submitted patch, 17: 3415762-17.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Here is a start on the test-only patch.

The last submitted patch, 20: 3415762-20.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Grabbing codesniffer stuff.

Better tests

Named one wrong. Should show 9 tests now.

Better comments and a couple of increment checks added on non attribute, non modal messages.

Committed as it's a simple enough fix, and I need the new tests in place for other work. Going to publish a new release. Feel free to follow up on this issue, I will leave it open.

Marking as fixed. Can clean up follow up in subsequent issue.

Automatically closed - issue fixed for 2 weeks with no activity.