- Issue created by @hartsak
- Status changed to Needs review
10 months ago 2:12pm 18 January 2024 - 🇫🇮Finland hartsak
Here's a simple patch for starters. Trying to use the media entity label for the title and providing a default value "Video" (translatable).
Also, noticed some problems in tests (unrelated) and tried to fix them too. - 🇫🇮Finland kekkis Pirkkala
Thanks for posting the issue! I happen to know of a solution that is already in use: https://github.com/Tampere/tampere-fi/blob/main/patches/media_entity_dre...
We could combine these approaches maybe?
- Status changed to Needs work
10 months ago 2:30pm 18 January 2024 - 🇫🇮Finland hartsak
Oh, you were fast! Nice that you have taken into account the translations too, I completely forgot about them.
I can test your approach too and provide a new patch. - Status changed to Needs review
10 months ago 2:57pm 18 January 2024 - 🇫🇮Finland hartsak
Ok, here's another try. I tried to combine your patch with mine. Hopefully I didn't mess up something there...
And by the way, how to use the latest version in tests? Now it seems only "media_entity_dreambroker 8.x-1.x-dev" is available in the "Test with" drop-down?
- 🇫🇮Finland kekkis Pirkkala
Thanks for the patch. The testing configuration is not up to date in this project, we should add a gitlab setup to get access to testing again.
- 🇫🇮Finland kekkis Pirkkala
I tried adding test support using Gitlab CI in #3481075 📌 Setup GitLab CI pipelines for phpcs, phpstan, eslint, composer validations Active but seems I ran out of competence and/or time. Will need to dive deeper into that at some point.
However, I would like to propose that we merge this and release it as part of the 2.1.1 release which is also going to introduce basic Drupal 11 support, albeit not for the tests.
Opinions for or against?
- 🇫🇮Finland hartsak
I haven't had any issues with the patch from #6, so I'm not against committing it to the module!
If it was officially committed to the module I wouldn't have to be using the patch. Automatically closed - issue fixed for 2 weeks with no activity.