- Issue created by @CRZDEV
- Merge request !34Issue #3415517: Horizontal tabs & base for others like vertical or accordion → (Merged) created by CRZDEV
- last update
11 months ago 3 pass - last update
11 months ago 3 pass - Status changed to Needs review
11 months ago 1:52pm 18 January 2024 VLSuite layout tabs module create with layout class basis to use into horizontal tabs or any other like accordion or vertical tabs.
For now added "Tabs horizontal with optional top & bottom (VLSuite)" with dynamic main regions, optional top & bottom like others. Also note that JS/CSS is minimal or empty due it will use bootstrap 5 related classes. Also library files can be overridden in case using other theme or customize provided template.
This requires https://www.drupal.org/project/vlsuite/issues/3415516 ✨ Add icon twig function to use it on templates Needs review or https://git.drupalcode.org/project/vlsuite/-/merge_requests/33/diffs; "Twig\Error\SyntaxError: Unknown "vlsuite_icon_font_icon" function." will appear if not added too. Please also include these changes (not adding into this MR due dedicated issue is used).
- Status changed to RTBC
11 months ago 11:37am 23 January 2024 - 🇪🇸Spain omarlopesino
It works okay for me and the code is fine.
I have some feedback that you can do now or later:
- When I add a new tab, I can't select this tab as default until I save the section configuration, and configure it again. THe AJAX should also refresh the default tab selector to select the new tab as default. It would me more friendly.
- After I add content to a specific tab, the first tab is chosen. This makes me go back to the tab I was. It would be nice to preserve the selected tab when an element is added to the section.
However, is RTBC ihmo.
Thanks @omarlopesino, those are improvements that can be made into an iteration if is okay for you too. Main functionality can already be merged.
- last update
11 months ago 3 pass - Status changed to Fixed
11 months ago 11:53am 23 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.