- Issue created by @catch
- First commit to issue fork.
- Status changed to Needs review
10 months ago 11:11pm 24 January 2024 - 🇬🇧United Kingdom catch
Green test run with the performance job schedule condition removed: https://git.drupalcode.org/project/drupal/-/jobs/687936.
- 🇺🇸United States smustgrave
Could the IS be updated for why change to core/tests/Drupal/FunctionalJavascriptTests/WebDriverCurlService.php was needed? Assuming for title this was going to be a pipeline only fix.
- 🇬🇧United Kingdom catch
It might need splitting to its own issue - it fixes things so that if chromedriver produces an error, we get the error message instead of a cryptic type error from PHP. Update the issue summary for now.
- Status changed to RTBC
10 months ago 5:36pm 29 January 2024 - 🇺🇸United States smustgrave
Thanks for updating, will lean on your expertise on this one too. Maybe a follow up should be made though for testing that chromedriver errors are properly captured, or is that overkill?
- 🇬🇧United Kingdom catch
Not a huge fan of testing the test framework - in this case the phpstan baseline needed to be updated, so we wouldn't be able to regress in this specific way again.
- 🇬🇧United Kingdom longwave UK
Going to open a followup to see if we can remove sudo from all tests, I don't think we need it on GitLab, and it makes the CI config more complicated.
I think it's fine to fix the WebDriverCurlService bug here, PHPStan was telling us there was an issue already so no need for a specific test.
Backported to 10.2.x to keep things in sync.
Committed and pushed b35de78f74 to 11.x and e48f905814 to 10.2.x. Thanks!
-
longwave →
committed e48f9058 on 10.2.x
Issue #3415296 by catch, sudhakartag1, smustgrave: Use a dedicated...
-
longwave →
committed e48f9058 on 10.2.x
- Status changed to Fixed
10 months ago 2:27pm 2 February 2024 -
longwave →
committed b35de78f on 11.x
Issue #3415296 by catch, sudhakartag1, smustgrave: Use a dedicated...
-
longwave →
committed b35de78f on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.