Call to a member function bundle() on null

Created on 17 January 2024, 11 months ago

Updated 20 September 2024, 3 months ago

Problem/Motivation

Hi! I've encountered an error using this module together with module Trash.

Error: Call to a member function bundle() on null in Drupal\paragraphs_report\ParagraphsReport->getParasFromNid() (line 333 of modules/contrib/paragraphs_report/src/ParagraphsReport.php).

It happens when you assume the load method from Storage is going to load the node entity. In my case, the load of the entity has NULL result because it's in the trash. So, this error produces an exception.

Steps to reproduce

- Drupal 10.1
- Php 8.1
- Module Trash installed

1. Delete a node. (the node will be moved to the trash bin)
2. You get the error.

Proposed resolution

In my opinion, there must be some control for when the entity cannot be loaded. Or at least, a try/catch for the exception.
For now, and for my case, I applied a little patch to return the original array when the node can't be loaded. But I am sure there will be a better solution.

Remaining tasks

Please, review and feel free to comment your ideas.

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇪🇸Spain missvengerberg

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @missvengerberg
Comment 11 months ago →
🇪🇸Spain missvengerberg
Comment 4 months ago →
🇺🇸United States generalredneck
If would check for !isset() or empty() in this case to make it more robust. we know that NULL == FALSE but not === as NULL is not . Also adding a comment so people understand why it's there.
Comment 4 months ago →
System Message

generalredneck → committed 893b6bed on 2.x
Issue #3415255 by missvengerberg, generalredneck: Call to a member...
Status changed to Fixed 4 months ago6:44pm 6 September 2024
Comment 4 months ago →
🇺🇸United States generalredneck
Thanks a ton, marking as fixed.
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024