Contrib.social

HTML escaped in notification email

Open on Drupal.org →
Created on 17 January 2024, over 1 year ago
Updated 13 February 2024, about 1 year ago

Problem/Motivation

Emailed notifications of available updates includes escaped html for all of the project details.

Steps to reproduce

  1. Install Update Manager Advanced (advupdate)
  2. Install HTML capable mailer: eg symfony_mailer_lite and mailsystem
  3. Configure update notifications to be processed by html capable mailer
  4. Trigger updates email when there are updates available
  5. Review email to find it has escaped contents making it hard to read

Proposed resolution

Pass the rendered content containing html to the mail function in a way that it trusts it, as a MarkupInterface object. Content is built using a build tree of description lists instead of themed unordered lists for easier formatting in plain text and html. Recommended to implement module specific implementation instead of using Markup::create() which is marked as @internal.

NB: Two additional trivial issues have been included as commits in this issue.

  • Do not force refresh update information when this function is being called by a function that just did a force refresh.
  • Remove unused project_downloads key from build array. Developers should be using composer instead of download urls.

Remaining tasks

  • ✅ Create fork and push code to it
  • ✅ Create MR

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇦🇺Australia elc

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024