Make flood event expiry window configurable

Created on 16 January 2024, 11 months ago
Updated 17 April 2024, 8 months ago

Currently failed verification attempts via magic code use the user.flood config for the flood event expiry windows.

It would be desirable to use explicit expiry windows for magic code flood events.

Extend the configuration form of the flood_control contrib module to allow easy configuration of flood config of this module.

Feature request
Status

Needs work

Version

1.0

Component

Code

Created by

🇦🇹Austria chfoidl Salzburg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @chfoidl
  • Status changed to Fixed 10 months ago
  • 🇦🇹Austria chfoidl Salzburg
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • 🇩🇪Germany Anybody Porta Westfalica

    @chfoidl if you're using the core flood services, shouldn't this better live in flood_control module?
    Add an expiration (setting) for blocked IPs and usernames Active

    You might suggest using flood_control in combination with this module to have all the advanced options and unblocking UI?

  • 🇦🇹Austria chfoidl Salzburg

    @anybody The flood_control contrib module provides just the UI portion for the Drupal Core flood module's functionality.

    Configuration of attempt count and expiry window is already part of Drupal Core, but there is no native UI for configuring those parameters.

    The flood_control contrib module does not need change anything to support any other module using the flood system. The unblock form supports any event registered via the core flood service, so it naturally works with the magic_code module as well.

    Right now there is no UI to configure the attempt count and expiry window specific to the magic_code module. If you want to configure it right now, you have to set those parameters in settings.php, but it would definetly make sense to expand on the flood_control configuration form to allow configuration of this module's flood settings.

  • Status changed to Needs work 8 months ago
  • 🇦🇹Austria chfoidl Salzburg
  • 🇩🇪Germany Anybody Porta Westfalica

    Thank you very very much for your feedback @chfoidl!

    Yes I agree. And I think both modules would benefit from that. Nice project btw. I just came across this issue and wanted to let you know :)

Production build 0.71.5 2024