Deprecated function: Creation of dynamic property Drupal\radioactivity\Plugin\Field\FieldWidget\RadioactivityReferenceWidget::$elementInfo is deprecated

chetan 11 → made their first commit to this issue’s fork.

Please check the above MR.

Using the diff from the MR as a patch and the deprecation warning is gone. Functionality seems not different from before.

The $elementInfo property never gets used as far as I can tell. If I'm right, it'd be better to remove it.

Yes, $elementInfo is unused and should be removed. MR !13 declares the property in order to make the error go away, but that's the wrong solution. The correct way to fix this is to just remove it entirely like @rupertj suggested in #6.

Note, if 🐛 Turn on GitLabCI testing Active gets committed, this and many other problems will show up in the test results. See the test output at https://git.drupalcode.org/issue/radioactivity-3480992/-/jobs/3063878 where this particular problem is evident. Likewise, once the tests are turned on, then any patch here which purports to solve the problem will also stop the test from failing. Win win.

I've removed the $elementInfo variable and refactored as required.

The changes look good to me, but when reviewing, I realised that the __create() and construct() methods are now identical to the parent class, so they could just be removed.

(Hi Darren! Been a while...)

True, had tunnel vision there, have removed those two methods.

Hi Rupert, yes its been ages; hope your doing fine :-)