- Issue created by @jonathan1055
- Merge request !42Issue #3414272: Show deprecations in gitlab pipeline tests β (Merged) created by jonathan1055
- last update
about 1 year ago 3 pass, 1 fail - π¬π§United Kingdom jonathan1055
The first step is to undo the recent fix, so that gitlab has something to show.
- last update
about 1 year ago 3 pass, 1 fail - π¬π§United Kingdom jonathan1055
There is relevant discussion on #3400979: Is SYMFONY_DEPRECATIONS_HELPER: weak correct for contrib deprecation testing needs? β
- last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - π¬π§United Kingdom jonathan1055
Took a while to get there but we now have a failing test at 10.2 for the deprecation error
https://git.drupalcode.org/issue/module_filter-3414272/-/jobs/623167Now fix the error and it should be green.
I have also added a test at next_minor (which is currently 10.2.x but will become 10.3.x when that branch is created) and next_major (which is 11.x).
- last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Composer require failure - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago 5 pass - π¬π§United Kingdom jonathan1055
Rebuilt the branch locally, as the gitlab UI 'rebase' button is no longer available. The "resolve conflicts" button added the latest commits into this branch, and made the 'changes' confusing. So I trashed the branch, re-created locally and force-pushed. It is now a clean MR again.
- last update
about 1 year ago 5 pass - last update
about 1 year ago 4 pass, 1 fail - π¬π§United Kingdom jonathan1055
That's good, as we can see that the "next minor" phpunit job reports the deprecation.
https://git.drupalcode.org/issue/module_filter-3414272/-/jobs/658013#L112Remaining self deprecation notices (1) 1x: Passing null to the $typedConfigManager parameter of ConfigFormBase::__construct() is deprecated in drupal:10.2.0 and must be an instance of \Drupal\Core\Config\TypedConfigManagerInterface in drupal:11.0.0. See https://www.drupal.org/node/3404140 1x in ModuleFilterSettingsFormTest::testModuleFilterSettingsForm from Drupal\Tests\module_filter\Kernel\Form
I have set this job to have 'allow_ failure:false' so that the pipeline ends amber not red. That is enough to alert us of deprecations that we can then fix.
- last update
about 1 year ago 5 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 9:00am 19 January 2024 - π¬π§United Kingdom jonathan1055
Now that I have removed the forced deprecation, the latest pipeline is all green
https://git.drupalcode.org/issue/module_filter-3414272/-/pipelines/79754But the previous pipeline shows the amber warning for 'next minor' when the deprecation was not fixed
https://git.drupalcode.org/issue/module_filter-3414272/-/pipelines/79460Currently 'phpunit next minor' is running core 10.2.3-dev which is the same as the plain 'phpunit' job. But the Gitlab Templates project maintains this setting and when 10.3.x-dev is created this will be used in the 'next minor' job. So we do not need to do anything, the core version will automatically test the newer realese when it is available.
Ready for review!
-
smustgrave β
committed 962e7931 on 4.x authored by
jonathan1055 β
Issue #3414272: Show deprecations in gitlab pipeline tests
-
smustgrave β
committed 962e7931 on 4.x authored by
jonathan1055 β
- πΊπΈUnited States smustgrave
Relying on your expertise on gitlab for this one.
- Status changed to Fixed
about 1 year ago 2:26pm 19 January 2024 - π¬π§United Kingdom jonathan1055
Thanks for the commit (and the confidence)
:-) Automatically closed - issue fixed for 2 weeks with no activity.