file_size deprecation rule keeps reporting as needs to be processed after replacement

The argument order is actually incorrect for d10 rules. Fun!

This means; AbstractDrupalCoreRector.php line 83 and 84 need to be switched. And then some tests will need to be updates.

The function:

     $result = DeprecationHelper::backwardsCompatibleCall(
        currentVersion: \Drupal::VERSION,
        deprecatedVersion: '10.3',
        currentCallable: fn() => Role::loadMultiple(),
        deprecatedCallable: fn() => user_roles(),
      );
 

The broken code in Drupal-rector:

    private function createBcCallOnCallLike(Node\Expr\CallLike $node, Node\Expr\CallLike $result, string $introducedVersion): Node\Expr\StaticCall
    {
        $clonedNode = clone $node;

        return $this->nodeFactory->createStaticCall(DeprecationHelper::class, 'backwardsCompatibleCall', [
            $this->nodeFactory->createClassConstFetch(\Drupal::class, 'VERSION'),
            $introducedVersion,
            new ArrowFunction(['expr' => $clonedNode]),
            new ArrowFunction(['expr' => $result]),
        ]);
    }

Thos arrowfunctions need swapping. The cloned node is the original node, the result is well, the result after rector.

I've applied the suggested changes from #3 in https://github.com/palantirnet/drupal-rector/pull/287.

Awesome, i'll test this.

The fact is gets double fixed is mostly because of the missing code in PHPStan, this will be fixed soon.

https://github.com/palantirnet/drupal-rector/pull/288

bbrala → credited mglaman → .

Merged, and releasing, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.