Import does not set default value for abstract text format

Open on Drupal.org →

Created on 11 January 2024, 11 months ago

Updated 8 May 2024, 8 months ago

Problem/Motivation

When a reference with an "abstract" field is imported, there is no handling of the text format, only the value. This results in a NULL value being populated into the database column for the text format, and the abstract rendering as plain text.

This can be further confusing if the reference is subsequently edited via the UI: Drupal will populate the first available text format as the default (such as "Basic HTML") giving the impression that there is a text format assigned. Upon save, the reference's abstract will now use the text format, creating a different output that prior to saving.

Steps to reproduce

1. Enable the `bibcite_import` module and the `bibcite_bibtex` module.
2. Import a simple reference with an abstract field that contains HTML, such as shown below, in BibTex format:

@misc{1,
  title = {test},
  abstract = {<p><strong>test123</strong></p>},
  year = {2005},
}

3. After the import is completed, view the reference. It will render the value of the abstract with encoded HTML, as in <p><strong>test123</strong></p>, applying no Drupal text format rendering.

Proposed resolution

During entity save, check if the abstract has a value and the text format has no value, which would be the case for all imports. If so, look up the highest-weighted text format in the site (via filter_formats()) and set the text format to that format. This will effectively provide a reliable fallback format, matching site configuration.

🐛 Bug report

Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States mark_fullmer Tucson

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!21Import does not set default value for abstract text format
Open
🇺🇸United States mark_fullmer
updated 11 months ago

Comments & Activities

Issue created by @mark_fullmer
Merge request !21Issue #3413916: Import does not set default value for abstract text format → (Open) created by mark_fullmer
Status changed to Needs review 11 months ago1:40am 11 January 2024
Comment 11 months ago →
🇺🇸United States mark_fullmer Tucson

Comment 9 months ago →

hxdef → committed a4d66613 on 3.0.x

Issue #3413916 by mark_fullmer: Import does not set default value for...

Comment 8 months ago →
🇫🇷France Toki Caen, Normandy
I have the same problem here after migration from D7 to D10 with references imported from Bibliography module (D7). Abstract (both english and french) and Notes (missing on the patch) are now in plain text in the database with html markups everywhere. I can't find a way to render them correctly, even with Views. I will try soon the patch and see if a new migration could solve this issue.
Status changed to Fixed 8 months ago8:35am 23 April 2024
Comment 8 months ago →
🇷🇺Russia hxdef
AardWolf → credited hxdef → .
Comment 8 months ago →
aardwolf
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Comment 8 months ago →
🇲🇩Moldova surfinspirit
I believe there is a typo in patch file
$abst_e = $this->get('bibcite_abst_e')->value;
should be
$abst_e = $this->get('bibcite_abst_e')->getvalue();
magic method 'value' returns only the value and the format cannot be determined.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024