- Issue created by @m4olivei
- First commit to issue fork.
- Merge request !157Icons display for items that a limited access user does not have access too → (Merged) created by kostyashupenko
- Status changed to Needs review
10 months ago 6:20am 12 January 2024 - Status changed to Needs work
10 months ago 4:45pm 12 January 2024 - 🇨🇦Canada m4olivei Grimsby, ON
I fixed the merge conflicts from 📌 Create an administration UI for managing Navigation Sections Needs work getting merged.
Found one small issue with the MR, otherwise looking good!
- Status changed to Needs review
10 months ago 4:18am 15 January 2024 - Status changed to Needs work
10 months ago 2:13pm 15 January 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Thanks for the changes! Those look good, we can resolve all those threads (I can't, but you should be able to as the MR owner).
I found one more thing that isn't strictly related to this issue, but is closely related and along the same lines. Even when the AdminNavigationBlock is empty, the wrapper markup from navigation-block.html.twig is still showing up. See screenshot below. Can we fix this as well, or otherwise file a followup?
- Status changed to Needs review
10 months ago 5:34am 16 January 2024 - Status changed to RTBC
10 months ago 4:33pm 16 January 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Looks great! Thanks for all the changes. RTBC for me.
- Status changed to Fixed
10 months ago 11:50am 17 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.