Icons display for items that a limited access user does not have access too

Created on 10 January 2024, 6 months ago
Updated 31 January 2024, 5 months ago

Problem/Motivation

While testing with a limited access user (eg. Author role in demo_umami), we noticed in the navigation side bar that we show icons for links that the user is not allowed to see, but the link and text is hidden.

Steps to reproduce

  • Install the navigation module
  • Login as a limited access, non-admin user, eg. Author role from demo_umami
  • Notice the navigation sidebar is broken looking

Proposed resolution

For users without access to items in the navigation bar, those items should not display at all. From a markup perspective, there should be no <li> at all for the item.

Remaining tasks

Implementation.

User interface changes

Fix broken UI for limited access users.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇨🇦Canada m4olivei Grimsby, ON

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @m4olivei
  • First commit to issue fork.
  • Status changed to Needs review 6 months ago
  • Status changed to Needs work 6 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    I fixed the merge conflicts from 📌 Create an administration UI for managing Navigation Sections Needs work getting merged.

    Found one small issue with the MR, otherwise looking good!

  • Status changed to Needs review 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON
  • Status changed to Needs work 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Thanks for the changes! Those look good, we can resolve all those threads (I can't, but you should be able to as the MR owner).

    I found one more thing that isn't strictly related to this issue, but is closely related and along the same lines. Even when the AdminNavigationBlock is empty, the wrapper markup from navigation-block.html.twig is still showing up. See screenshot below. Can we fix this as well, or otherwise file a followup?

  • Status changed to Needs review 5 months ago
  • Status changed to RTBC 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Looks great! Thanks for all the changes. RTBC for me.

  • 🇪🇸Spain ckrina Barcelona

    Fixed! Thanks both!

  • Status changed to Fixed 5 months ago
  • 🇪🇸Spain ckrina Barcelona
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    3 months ago
    Total: 53s
    #122277
  • Pipeline finished with Success
    3 months ago
    Total: 282s
    #122270
  • Pipeline finished with Success
    3 months ago
    #122285
  • Pipeline finished with Success
    3 months ago
    Total: 209s
    #122278
  • Pipeline finished with Success
    3 months ago
    Total: 148s
    #122290
  • Pipeline finished with Success
    3 months ago
    #122303
  • Pipeline finished with Success
    3 months ago
    Total: 440s
    #122312
  • Pipeline finished with Success
    3 months ago
    Total: 268s
    #123135
  • Pipeline finished with Success
    3 months ago
    Total: 53s
    #123269
  • Pipeline finished with Canceled
    3 months ago
    Total: 1236s
    #124354
  • Pipeline finished with Success
    3 months ago
    Total: 1361s
    #124371
  • Pipeline finished with Success
    3 months ago
    Total: 149s
    #137769
  • Pipeline finished with Success
    3 months ago
    Total: 152s
    #137780
  • Pipeline finished with Failed
    3 months ago
    Total: 43s
    #137940
  • Pipeline finished with Success
    about 2 months ago
    Total: 227s
    #166037
  • Pipeline finished with Failed
    about 1 month ago
    Total: 43s
    #175741
  • Pipeline finished with Failed
    about 1 month ago
    #175882
  • Pipeline finished with Failed
    about 1 month ago
    Total: 42s
    #175906
  • Pipeline finished with Canceled
    23 days ago
    Total: 79s
    #190337
  • Pipeline finished with Success
    23 days ago
    Total: 1178s
    #190338
  • Pipeline finished with Success
    22 days ago
    Total: 1208s
    #190730
  • Pipeline finished with Failed
    22 days ago
    Total: 1134s
    #191007
  • Pipeline finished with Failed
    22 days ago
    Total: 1294s
    #191111
  • Pipeline finished with Success
    22 days ago
    Total: 1109s
    #191136
  • Pipeline finished with Failed
    21 days ago
    Total: 97s
    #191967
  • Pipeline finished with Failed
    19 days ago
    Total: 46s
    #193735
Production build 0.69.0 2024