- Issue created by @dww
- Status changed to Needs review
10 months ago 6:29am 10 January 2024 - πΊπΈUnited States dww
This doesn't depend on the other issue at all, we could commit this here any time.
I don't love having to add the extra layer of indentation, but the code you inherited was already a bit of a mess, so it's not so easy to do it otherwise without a larger code refactoring.
- πΊπΈUnited States mlncn Minneapolis, MN, USA
The patch did not apply, but i think i brought this in faithfully except the ief_items and ief_add_existing_widget properties which did not exist in this module and do not yet exist in Inline Entity Form either. Talking about these lines that existed in the patch both as if already there and only getting indented in for the conditional:
'#ief_items' => $items, '#ief_add_existing_widget' => $this->getSetting('add_existing_widget'),
- πΊπΈUnited States mlncn Minneapolis, MN, USA
OK i see those are from β¨ Support the 'add_existing_widget' setting from #2683125 Needs review as i thought and should have already checked. Still willing to adopt everything that is stuck getting into IEF and then, i hope, getting everything into IEF (in particular β¨ Prioritize 'add existing' in nested entity creation UX to prevent duplication. Needs work ) and obsoleting this module entirely!
- Status changed to RTBC
3 months ago 1:10am 24 August 2024