Support the 'add_existing_widget' setting from #2683125

Created on 9 January 2024, 6 months ago

Problem/Motivation

The way this module extends the IEF complex widget is a little fragile. 😅 I found that if I add the feature at ✨ Allow select widget for "Add existing items" Needs work , this widget starts to fail and needs a little bit of code updated to keep working.

Steps to reproduce

Setup a 10.2.x core test site with IEF and ief_complex_open.
Apply the latest patch from ✨ Allow select widget for "Add existing items" Needs work to IEF.
Add an entity reference field to a node type, and try to configure the widget to use ief_complex_open + a select widget for add_existing_widget.
Try to use the form. Experience WSOD.

Proposed resolution

Add code to keep working as IEF changes.
Consider if we should be more careful in IEF about "BC" for modules like this that are extending the widget class (but not defining their own schema, etc).

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request

Status

Needs review

Version

1.0

Component

Code

Created by

🇺🇸United States dww

Live updates comments and jobs are added and updated live.

Merge Requests

!4Support the 'add_existing_widget' setting from #2683125
Open
🇺🇸United States dww
updated 6 months ago

Comments & Activities

Issue created by @dww
Status changed to Needs review 6 months ago2:58am 9 January 2024
Comment 6 months ago →
🇺🇸United States dww
Here's a patch, although it should probably be postponed on ✨ Allow select widget for "Add existing items" Needs work landing. 😅
Comment 6 months ago →
🇺🇸United States dww
Merge request !4[#3413340]: Support add_existing_widget from [#2683125] → (Open) created by dww
Comment 6 months ago →
🇺🇸United States dww
Hiding patch, there's an MR for this now. Although there's no CI configured for this project, either DrupalCI nor GitLab CI, so it kinda doesn't matter. 😉

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024