When set to "count based" old records never get expunged

HI @nathan573,

this issue has been fixed, please review the patch.

Thanks
Samit K.

Thank you very much samit.310@gmail.com! I've tested this patch out for at least a month now and it's working.

Cheers!

The MR is different from the provided patch as it adds the additional option for anonymous users if Count based is selected. Hiding that file.
Tested the functionality manually:

1. selected count based
2. set Max records 1 and 2
3. set the delete anonymous records after 1 hour
4. created two content types that are tracked
5. visited as logged in user and as anonymous use
6. checked that the record in DB correctly stores only 1 record when 1 was set up and 2 when max was set to 2
7. came back after the hour has passed and checked that the anonymous records were removed but the logged in one stayed.

Functionality works as expected.

I changed the naming of 1 hours to 1 hour, updated phpcs indentation, renamed enitity to entity and ignored basetable (cSpell reported as an issue) and added cSpell ignore to readme for maintainers.

As the review was also requested to be done by @bostian, leaving the status to needs review, but from my POV, it can be merged.

@deaom → I've requested review from @boshtian because I wanted someone to review my work prior to merging. Since you've tested and reviewed work done I think that additional reviews aren't needed so I'm marking this as Fixed, and will include this issue into next release. After release is published I will close this ticket.