Uncaught GuzzleHttp\Exception\ConnectException in remote post hander

Here's a basic fail test.

The last submitted patch, 2: webform-connect_exception-3413266-2-FAIL.patch, failed testing. View results →

I'm not sure why there were 38 failures (?!) but here's the one I was trying to introduce:

Webform.Drupal\Tests\webform\Functional\Handler\WebformHandlerRemotePostTest
✗	
Drupal\Tests\webform\Functional\Handler\WebformHandlerRemotePostTest
exception: [Other] Line 0 of sites/default/files/simpletest/phpunit-48.xml:
PHPUnit Test failed to complete; Error: PHPUnit 9.6.15 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\webform\Functional\Handler\WebformHandlerRemotePostTest
E                                                                   1 / 1 (100%)

Time: 00:09.847, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\webform\Functional\Handler\WebformHandlerRemotePostTest::testRemotePostHandler
Behat\Mink\Exception\ExpectationException: The string "Unable to process this submission. Please contact the site administrator." was not found anywhere in the HTML response of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:794
/var/www/html/vendor/behat/mink/src/WebAssert.php:324
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:540
/var/www/html/modules/contrib/webform/tests/src/Functional/Handler/WebformHandlerRemotePostTest.php:170
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

Here's a fix.

I also added assertions for the exception messages.

The last submitted patch, 5: webform-connect_exception-3413266-5.patch, failed testing. View results →

I have no idea what's causing those other 36 test fails. I think that's unrelated, so I'm going to flip this back to NR.

I think I've seen those failures on other webform issues. HEAD could be failing.

This MR could be creating config validation issues because the remote post status code could now be a string.

We should try to see if the No Response status code addresses this concern/issue.

@see 🐛 Improve error handling for unreachable endpoints while using Remote Post handlers Fixed

Hi @jrockowitz!

> This MR could be creating config validation issues because the remote post status code could now be a string.

I don't think that's a problem here.. There's no schema related to those changes to webform.webform.test_handler_remote_post.yml. It's part of multiline string in the yaml. It's kind of funky, but it sseemed like the path of least resistance to have some decent test coverage for these Guzzle exceptions.

> We should try to see if the No Response status code addresses this concern/issue.

Looking at the commit for that issue, it doesn't look like that will totally solve the problem with the guzzle exception. There are no changes to the code that runs prior to this uncaught exception. The issue here is fundamentally about a change made in Guzzle 7 to the structure of exceptions. I think it needs its own solution.

Confirming this patch works for me.

This is a perfect patch. Thanks

I created an MR which should be RTBC if all tests pass.