Contrib.social

Help for tome:static-export-path command shouldn't say '*a* specific path'

Open on Drupal.org →
Created on 8 January 2024, 11 months ago
Updated 11 April 2024, 8 months ago

Problem/Motivation

The help for this command says:

Exports static HTML for a specific path.

Arguments:
 chunk A comma separated list of paths.

It's not *a* specific path if you can pass in a list of paths.

Steps to reproduce

Proposed resolution

Change it to say 'specific paths'.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

RTBC

Version

1.0

Component

Tome Static

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @joachim
  • First commit to issue fork.
  • Status changed to Needs review 11 months ago
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 11 months ago
    Waiting for branch to pass
  • Comment 11 months ago →
    🇮🇳India viren18febS

    I have changed the text and added a patch for this ,please review

  • Status changed to Needs work 11 months ago
  • Comment 11 months ago →
    🇬🇧United Kingdom joachim

    Thanks for the patch.

    It's changing the wrong text though. The incorrect text is this one:

    > Exports static HTML for a specific path.

  • Status changed to Needs review 11 months ago
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 11 months ago
    Waiting for branch to pass
  • Comment 11 months ago →
    🇮🇳India viren18febS

    Hi @joachim
    I have removed a from specific path and updated a patch file for this .please review.
    Thanks

  • Comment 11 months ago →
    🇬🇧United Kingdom joachim

    You're still changing the wrong text. The text in the call to addArgument() is correct.

    You need to find and fix this text: 'Exports static HTML for a specific path.'.

  • Merge request !14issue-3413164-help-for-tomestatic-export-path-fixes → (Open) created by viren18febS
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 11 months ago
    Waiting for branch to pass
  • Comment 11 months ago →
    🇮🇳India viren18febS

    @joachim

    You're still changing the wrong text. The text in the call to addArgument() is correct.

    You need to find and fix this text: 'Exports static HTML for a specific path.'.

    Sorry for inconvenience, i had updated the same patch file, Now i have added the MR for changes, please review.

  • Status changed to Needs work 10 months ago
  • Comment 10 months ago →
    🇬🇧United Kingdom joachim

    Nearly there! Should now say 'paths' plural.

  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 10 months ago
    Waiting for branch to pass
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇮🇳India viren18febS
  • Status changed to RTBC 8 months ago
  • Comment 8 months ago →
    🇩🇪Germany marcoliver Neuss, NRW, Germany

    Looks correct now. Marking RTBC.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024