rename $static variable to staticGenerator / static_generator

Created on 8 January 2024, 6 months ago

Updated 9 January 2024, 6 months ago

Problem/Motivation

Having variables called $static and $this->static is confusing in a language like PHP where static is a keyword with a particular meaning (multiple, in fact).

I'm finding it's adding to mental load while reading the code.

Steps to reproduce

Proposed resolution

Rename to $this->staticGenerator / $static_generator throughout.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @joachim
Comment 6 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
This will be a BC break
Comment 6 months ago →
🇬🇧United Kingdom joachim
The cases where it's just $static inside a function will be fine.

For class properties, add the new property name, and use the same logic as DeprecatedServicePropertyTrait to deprecate the old name while making it available.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024