SDC components: Fix JSON schema usage

So glad to hear you are using Prototype for your testing and thank you for your detailed feedback, I appreciate it! I've opened a MR with updates based on the feedback, if you could review it that would be great.

Ok, I will do the review

breadcrumb

It seems my feedback about breadrcumb presenter template was not clear enough.
I was not suggesting to add the separator prop in templates/page/page.html.twig but to be sure breadcrumb.html.twig is sending the expected data to breadcrumb component.

Empty components

Some components have no props and no slots:

• sidebar
• icons (hidden folder)
• tabs

I am not sure SDC is loading slots without a definition:

slot:
  content: {}
  link: {}

Also, 2 components have placeholders props "due to a core issue":

• menu
• menu--navigation

jldust → changed the visibility of the branch 3413130-sdc-components-fix to hidden.

jldust → changed the visibility of the branch 3413130-sdc-components-fix to active.

I realized that I miss read your feedback and have updated the component accordingly, let me know if this works!

Also we are aware of the empty props and are currently working to update those components, the original core issue is here: https://www.drupal.org/project/drupal/issues/3385283 🐛 Components without props throw error Fixed

We have pulled in these changes to the main 5.x branch, these updates will be included in the next tagged release.