Using a translatable string as a category for field type is deprecated in drupal:10.2 (Commerce)

Here's a patch for it

Well I think we need Commerce to define a field type category, as indicated in the change record.
We need a commerce.field_type_categories.yml and we might as well define an icon etc.

There is no branch test at 10.2 to compare against, but I don't think there is test coverage for all of these. A quick grep of the source shows there are six more places that need to be fixed:

./modules/order/src/Plugin/Field/FieldType/AdjustmentItem.php: *   category = @Translation("Commerce"),
./modules/tax/src/Plugin/Field/FieldType/TaxNumberItem.php: *   category = @Translation("Commerce"),
./modules/checkout/src/Plugin/Block/CheckoutProgressBlock.php: *   category = @Translation("Commerce")
./modules/price/src/Plugin/Field/FieldType/PriceItem.php: *   category = @Translation("Commerce"),
./modules/cart/src/Plugin/Block/CartBlock.php: *   category = @Translation("Commerce")
./src/Plugin/Field/FieldType/RemoteIdItem.php: *   category = @Translation("Commerce"),

@sidharth_soman I am not working on these changes, so you are welcome to add these to your patch. It would be useful to have a branch test of 3.0.x at 10.2 to see if there are any deprecation warnings. You may want to prove that first.

Then add the commerce.field_type_categories.yml afterwards, so that the UI has the translation available.

@jonathan1055: Gitlab CI I think uses D10.2 (probably even the dev 10 version).

Ah yes thanks, gitlab pipelines have just recently been updated to run against 10.2
I can see on https://git.drupalcode.org/project/commerce/-/pipelines/72224/test_report there are some Ajax failures which the 10.1 pipeline did not have, but there are no deprecation warnings. This could be becuase (a) the Gitlab template is not configured to show them or fail for them, or (b) the code that would create the warnings is not covered by the tests. From a standing start, I would have said (a) is the likely reason, because you do have a huge amount of test coverage here. But the patch from #2 did not have the deprecation warnings for the six additional places that need fixing.

I know that the deprecation errors do show on drupal.org testing, so here's a patch which does not make that change, to see what drupal.org shows.

czigor → changed the visibility of the branch 3413020-using-a-translatable to hidden.

czigor → closed merge request !235

Merged, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.