GitLab CI - PHPStan - "Unsafe usage of new static()"

------ -------------------------------------------------------------------------------------------- Line responsive_image_link_formatter/src/Plugin/Field/FieldFormatter/ResponsiveImageLinkFormatter.php ------ -------------------------------------------------------------------------------------------- 85 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ -------------------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------ Line src/Plugin/Field/FieldFormatter/ImageLinkFormatter.php ------ ------------------------------------------------------------------------------ 81 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ [ERROR] Found 2 errors

Comments & Activities

Issue created by @dydave
Comment 9 months ago →
🇫🇷France dydave
Comment 9 months ago →
🇫🇷France dydave
Comment 9 months ago →
🇫🇷France dydave
Merge request !2Issue #3412951 by DYdave: Automated testing on GitLab CI: Fixed PHPStan errors... → (Merged) created by dydave
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 9 months ago
17 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 9 months ago
17 pass

Comment 9 months ago →

System Message

DYdave → committed 97460764 on 2.1.x

Issue #3412951 by DYdave: Automated testing on GitLab CI: Fixed PHPStan...

Status changed to Fixed 9 months ago4:29am 7 January 2024
Comment 9 months ago →
🇫🇷France dydave
Quick follow-up on this ticket:

Fixed PHPStan errors 'Unsafe usage of new static().' by declaring plugin constructor methods as final, as suggested in the issue summary.

Updated module's documentation to explain how its 'FieldFormatter' plugin classes could be extended.

The changes have been merged with the branch 2.1.x and the tests went all back to green ✅:
https://git.drupalcode.org/project/image_link_formatter/-/pipelines/72896

Feel free to let us know if you have any questions or concerns on any of the changes from this ticket's merge request, or the ticket in general, we would surely be happy to help.
Thanks again very much to everyone for the great help on fixing this issue.
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

GitLab CI - PHPStan - "Unsafe usage of new static()"

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!2GitLab CI - PHPStan - "Unsafe usage of new static()"
Merged

Comments & Activities

GitLab CI - PHPStan - "Unsafe usage of new static()"

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!2GitLab CI - PHPStan - "Unsafe usage of new static()"Merged

Comments & Activities

!2GitLab CI - PHPStan - "Unsafe usage of new static()"
Merged