- Issue created by @danielspeicher
-
danielspeicher →
committed f55099c7 on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
danielspeicher →
committed f55099c7 on 1.0.x
-
danielspeicher →
committed 662a4012 on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
danielspeicher →
committed 662a4012 on 1.0.x
-
danielspeicher →
committed 520e6dee on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
danielspeicher →
committed 520e6dee on 1.0.x
-
danielspeicher →
committed 77c8dafe on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
danielspeicher →
committed 77c8dafe on 1.0.x
-
danielspeicher →
committed 834204a5 on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
danielspeicher →
committed 834204a5 on 1.0.x
-
danielspeicher →
committed 0cee97f7 on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
danielspeicher →
committed 0cee97f7 on 1.0.x
-
danielspeicher →
committed 69a8f1a0 on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
danielspeicher →
committed 69a8f1a0 on 1.0.x
-
danielspeicher →
committed 90722c68 on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
danielspeicher →
committed 90722c68 on 1.0.x
-
danielspeicher →
committed 104bb10b on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
danielspeicher →
committed 104bb10b on 1.0.x
-
danielspeicher →
committed abe52854 on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
danielspeicher →
committed abe52854 on 1.0.x
- Status changed to Needs review
10 months ago 12:48pm 31 January 2024 - 🇩🇪Germany danielspeicher Steisslingen
This is ready for a first review, including the issue for the configuration https://www.drupal.org/project/invoice_ninja/issues/3412582 📌 Implement config settings page Active .
But please consider that the exception handling https://www.drupal.org/project/invoice_ninja/issues/3416633 📌 Exception Handling Active
and the handling of multiple contacts https://www.drupal.org/project/invoice_ninja/issues/3416659 ✨ Enable multiple contacts for clients Active are in progress and in other issues. - 🇩🇪Germany jurgenhaas Gottmadingen
I've reviewed the code for this issue and it looks pretty good. I've made some changes though, you can see them in the commit. Here are some comments:
- Constants should have an access control identifier
- The pattern around
getInvoiceNinjaClient()
is such that instead of using$this->invoiceNinja
we're using$this->getInvoiceNinjaClient()
which sets and returns the initialized object - For the remote
update
calls, we don't need to receive the object for the remote ID as we already know that ID that doesn't change during an update - For updating invoices, there was a copy&paste issue that mixed up client and invoice IDs
Leaving the issue at NR, please feel free to revert my changes when needed.
-
jurgenhaas →
committed 69ecbd86 on 1.0.x
Issue #3412583 by danielspeicher: Implement methods to synchronize
-
jurgenhaas →
committed 69ecbd86 on 1.0.x
- Status changed to Fixed
9 months ago 12:43pm 15 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.