- Issue created by @b_sharpe
- First commit to issue fork.
- Assigned to bobi-mel
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
11 months ago Not currently mergeable. - last update
11 months ago 4 fail - last update
11 months ago 2 pass - 🇨🇦Canada b_sharpe
It appears the UI is different between 10.1 as and 10.2, so we'll need to check versions for tests here or find a solution that works for both.
Something like https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
- Status changed to Needs work
11 months ago 6:54am 9 January 2024 - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
11 months ago Not currently mergeable. - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
11 months ago Not currently mergeable. - last update
11 months ago 2 fail - last update
11 months ago 2 pass - last update
11 months ago 2 fail - 🇺🇦Ukraine bobi-mel
HI @b_sharpe
I checked why tests fail on Drupal 10.2
It changed not only the labels for buttons but also the UI itself when adding fields, especially for fields with text. Previously, the field was selected in a selector, now they are displayed in a container in the form and for text fields, an input is added in which you need to
to select this simple field or a formatted field.
Since changes in tests require a lot of time, I wanted to clarify how best to implement this task. I propose to create 3 methods for creating fields for different cases for different cases.
- the first one for UI for Drupal 10.1 and below (we'll leave the old one)
- separate methods for boolean and text fields for Drupal 10.2Will this solution be correct in your opinion?
- last update
10 months ago 2 pass - last update
10 months ago 2 pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
10 months ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
10 months ago 5:33am 24 January 2024 - 🇺🇦Ukraine bobi-mel
Hello @b_sharpe
I've added changes to the test methods for adding fields. While working, I found out that the problem was not so much in the tests but in the field creation procedure itself. I added logic for the correct passing of the test depending on the version of the Drupal kernel. Please check it. -
b_sharpe →
committed f52eb651 on 2.0.x authored by
bobi-mel →
Issue #3412398 by D-XPERT: Fix failing tests for D10.1 / D10.2
-
b_sharpe →
committed f52eb651 on 2.0.x authored by
bobi-mel →
- Status changed to Fixed
9 months ago 10:42pm 13 February 2024 -
b_sharpe →
committed f52eb651 on 2.1.x authored by
bobi-mel →
Issue #3412398 by D-XPERT: Fix failing tests for D10.1 / D10.2
-
b_sharpe →
committed f52eb651 on 2.1.x authored by
bobi-mel →
Automatically closed - issue fixed for 2 weeks with no activity.