Permissions filter test - waitForNoText() also needs waitForText()

It is to do with admin access permissions being tightend up between core 10.1 and 10.2

I have seen this before on
🐛 Failing phpunit test: h1[text() = "Administration"] not found Needs review and
💬 Access permission to /admin/ changed between 10.1 and 10.2 Active

Adding permission 'use administration pages' should fix it.

The permission was not the problem. I think it is failing the phpunit job because the core patch from 🐛 Modules uninstall filter does not filter by machine name Needs work is for 10.2 and it does not apply at core 10.2

That should be fixable, becuase there is a 10.2 MR on that issue too.

OK its not anything to do with permissions. The browser output artifacts show that the permissions page is being shown initially, with all permissions. But when entering the first filter values it matches with nothing, hence the test failure.
I suspect that some form classes have been changed from 10.1 to 10.2 for the theme being used in the javascript test.

The drupalci test pases, because it is being run at core 10.1. The pipeline is on 10.2

I have added an op-in to test the previous minor branch (10.1) in addition to 10.2 and then allowed 10.2 to fail with warning. The permissions filter works perfectly well at 10.2 when testing manually in the UI. So I suggest we merge this change so that we can see a green pass at 10.2 and amber warning at 10.2 instead of red.

Then we can work on why the test fails, but until we can fix it we need to keep testing at 10.1 and show it is green

Adding extra drupalGet did not help. Now trying extra waitForText()

All green, this good for review?

Yes, except we might want to do 📌 Add pipeline phpunit job for previous core version Needs review first. Then I will adjust the changes on this mr.

Fixed the merge conflicts from merging the pipeline change.

All green! Now jumping over the last eslint ticket.

Excellent, thank you. I was just coming back here to do the rebase. But at least it was easy, ie. we did not want any changes from .gitlab-ci.yml

The screen grab is a nice useful thing in the javascript test. I showed that the test is using Claro even though the saved html pages display as Stark.

html file

automated screen grab

I don't know exactly what caused the change in javascript interaction behavior from 10.1 to 10.2, but I am assuming there were new versions of things. The processing was waiting for text to disappear from the page on entering a filter value, using our custom waitForNoText() function. This was adequate in 10.1 but at 10.2 maybe the page is re-rendererd in a different order? or slower? The text to be hidden was not found, so the test proceeded. But the text we want to find was not yet showing at that point. So I added a waitForText() on the string we did want to see, and that solved the problem.

Adding info to the title to help future searching.

Automatically closed - issue fixed for 2 weeks with no activity.