- Issue created by @roderik
- Status changed to Needs review
about 1 year ago 11:34am 3 January 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Created 1 MR with phpunit test only (fail), 1 MR with the fix on top of it.
I had to include all of 🐛 Respect installations with base paths Needs review in order to make the phpunit output make sense, so for a review, you'll need to completely disregard the changes made to files
modules/lupus_decoupled_ce_api/src/BackendApiRequest.php
and (new)tests/src/Unit/LupusDecoupledBackendApiRequestTest.php
(i.e. the first 10 commits)Only look at
tests/src/Functional/LupusDecoupledApiResponseTest.php
(same commit == same changes in both MRs)modules/lupus_decoupled_ce_api/src/PathProcessor/LupusFrontendPathProcessor.php
(in 'real' MR)
- Status changed to Needs work
about 1 year ago 2:18pm 3 January 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
I guess not "needs review" until I comment the fix...
- Status changed to Needs review
about 1 year ago 10:06am 4 January 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
It's fine, I don't think it needs public comments because it was commented elsewhere internally.
- 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Patch file with just the actual code change from this issue - not the phpunit test or the stuff from 🐛 Respect installations with base paths Needs review
- 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
I did not change the code since I originally opened the merge requests...
However, I realized that the original "tests green" MR is not for merging, because it contains 🐛 Respect installations with base paths Needs review .
So I created separate merge requests:
- to prove the fix still works / stay 'green', but not for merging) has #3409409 merged in
- for review merging (but not green)
- Status changed to Fixed
about 1 year ago 12:17pm 9 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.