- Issue created by @AstonVictor
- First commit to issue fork.
- Status changed to Needs review
9 months ago 10:57am 3 January 2024 - 🇮🇳India viren18febS
I have added a patch for the changes, please review
- Status changed to Needs work
9 months ago 11:16am 3 January 2024 - 🇺🇦Ukraine AstonVictor
Hi @viren18febS,
your code is incorrect and is not working. e.g.
format()function requires to have$timestampas a first parameter but you use a string (date format). - Assigned to paulrad
- Status changed to Active
9 months ago 2:36pm 3 January 2024 - Issue was unassigned.
- Status changed to Needs review
9 months ago 4:57pm 3 January 2024 - Status changed to Needs work
9 months ago 5:16pm 3 January 2024 - 🇺🇦Ukraine AstonVictor
I'm afraid we cannot use
time()function as well. It should be replaced with\Drupal::time()->getRequestTime()call. you can find more info - https://www.drupal.org/node/2785211 → - Status changed to Needs review
9 months ago 8:43am 4 January 2024 - 🇺🇦Ukraine AstonVictor
AstonVictor → changed the visibility of the branch 3412022-replace-date-php to hidden.
-
AstonVictor →
committed 8737aab1 on 1.0.x authored by
paulrad →
Resolve #3412022 "Replace date php 1.0.x"
-
AstonVictor →
committed 8737aab1 on 1.0.x authored by
paulrad →
- Status changed to Fixed
9 months ago 9:30am 4 January 2024 - 🇺🇦Ukraine AstonVictor
Hi @paulrad,
thanks for your contribution. The MR is reviewed and merged.
Automatically closed - issue fixed for 2 weeks with no activity.