- Issue created by @maenjuel
- 🇺🇸United States mfb San Francisco
I've only tested the drupal 7 version with LibreJS browser extension, so contributions are welcome + encouraged.
Sounds like possibly some improvements could be contributed to LibreJS as well.
- 🇺🇸United States mfb San Francisco
I filed 🐛 Use standardized SPDX license identifiers Active to get core to use the standard SPDX license identifier, i.e. remove the "GNU-" from "GNU-GPL-2.0-or-later"
Although it sounded like LibreJS extension might also need to be patched to support the standard identifiers...
- 🇺🇸United States mfb San Francisco
I still haven't tested the 2.x branch with LibreJS browser extension, but I suspect there are three issues:
- LibreJS extension might check the URL of the license - it might need to match the "canonical" URL of the license to be recognized?
- We need to provide a source URL for every script. The source URL could just link to the script itself.
- We need to list all aggregated javascript files on the jslicense page, otherwise they will not be recognized.
- 🇺🇸United States mfb San Francisco
Looked thru the related code briefly, and unlike in Drupal 7, I didn't yet find a super simple way to generate a list of aggregated JS files.
So, we might have to jump thru some hoops to build and maintain this list? I do have some ideas for how to do that, though.
In Drupal 7 this could be gathered simply via
variable_get('drupal_js_cache_files');
- Merge request !2Issue #3411951 by mfb, maenjuel: List aggregated JS on the jslicense page → (Merged) created by mfb
- last update
8 months ago 1 pass - Status changed to Needs review
8 months ago 11:29pm 3 April 2024 - 🇺🇸United States mfb San Francisco
Here's a pretty hacky attempt to maintain a list of aggregated JS that we can render on the jslicense page.
Ideally there is a much more elegant way to do this that someone could suggest :)
- last update
8 months ago 1 pass - last update
8 months ago 1 pass - last update
8 months ago 1 pass - last update
8 months ago 1 pass - last update
8 months ago 1 pass - last update
8 months ago 1 pass - last update
8 months ago 1 pass - last update
8 months ago 1 pass - last update
8 months ago 1 pass - last update
8 months ago 1 pass - last update
8 months ago 1 pass - 🇺🇸United States mfb San Francisco
@maenjuel if you have time to test out the merge request on this issue, it looks like I have this working.
We may need to add additional "canonical" license URLs for contrib modules that use other licenses.
- last update
7 months ago 1 pass - last update
7 months ago 1 pass - last update
7 months ago 1 pass 54:39 49:36 Running- last update
7 months ago 2 fail - last update
7 months ago 2 fail - last update
7 months ago 2 fail - last update
7 months ago 1 pass - 🇺🇸United States mfb San Francisco
I don't think LibreJS browser extension needs to be changed at all (except that it would be quite helpful if it accepted "MIT" as a synonym for "Expat")
For compatibility with LibreJS browser extension, what I'm now doing is rewriting "GNU-GPL-2.0-or-later" to "GPL-2.0-or-later" and "MIT" to "Expat"
25:12 23:50 Running- last update
7 months ago 1 pass - last update
7 months ago 1 pass - last update
7 months ago 1 pass - last update
7 months ago 1 pass - last update
7 months ago 1 pass - last update
7 months ago 1 pass - Status changed to Fixed
7 months ago 11:54pm 9 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇨🇭Switzerland maenjuel
Just saw that there has been a lot of work on that issue. Just wanted to say thanks to fix things. Much appreciated!