Fix phpcs Drupal.Classes, DrupalPractice.FunctionCalls, SlevomatCodingStandard.PHP, Drupal.Semantics

phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme modules/custom/pathauto/ --sniffs="Drupal.Classes.UnusedUseStatement,DrupalPractice.FunctionCalls.InsecureUnserialize,SlevomatCodingStandard.PHP.ShortList,Drupal.Semantics.FunctionT" -s

FILE: tests/src/Functional/PathautoBulkUpdateTest.php ------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse) ------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------- FILE: tests/src/FunctionalJavascript/PathautoUiTest.php ----------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse) ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: pathauto.module ----------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------- 168 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead | | (Drupal.Semantics.FunctionT.BackslashSingleQuote) ----------------------------------------------------------------------------- FILE: pathauto.install ------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------ 137 | ERROR | [x] list(...) is forbidden, use [...] instead. | | (SlevomatCodingStandard.PHP.ShortList.LongListUsed) ------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------ FILE: src/Entity/PathautoPattern.php ------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------ 418 | ERROR | [x] list(...) is forbidden, use [...] instead. | | (SlevomatCodingStandard.PHP.ShortList.LongListUsed) ------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------ FILE: src/Plugin/migrate/source/PathautoPattern.php ------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------- 98 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. | | (DrupalPractice.FunctionCalls.InsecureUnserialize.InsecureUnserialize) 117 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. | | (DrupalPractice.FunctionCalls.InsecureUnserialize.InsecureUnserialize) -------------------------------------------------------------------------------

Comments & Activities

Issue created by @zniki.ru
Merge request !64Issue #3411804 Fix several phpcs → (Merged) created by zniki.ru
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
last update 11 months ago
48 pass
Comment 11 months ago →
🇷🇺Russia zniki.ru
Ready for review.
Status changed to Needs review 11 months ago11:06pm 1 January 2024
Comment 11 months ago →
🇷🇺Russia zniki.ru
Pipeline finished with Failed
11 months ago
Total: 295s
#70313
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
48 pass
Pipeline finished with Success
10 months ago
Total: 357s
#75931
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
48 pass
Comment 10 months ago →
🇷🇺Russia zniki.ru
Update MR, add phpcs.xml file and exclude rules that will be fixed in different issues.
Gitlab CI check phpcs passed.
Pipeline finished with Success
10 months ago
Total: 285s
#79100
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
48 pass
Pipeline finished with Success
10 months ago
Total: 397s
#80007
Comment 10 months ago →
🇷🇺Russia zniki.ru
Update IS
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
48 pass
Pipeline finished with Success
10 months ago
#85008
Pipeline finished with Skipped
9 months ago
#88258
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
last update 9 months ago
48 pass
Comment 9 months ago →
System Message

Berdir → committed 4b09f4e6 on 8.x-1.x authored by Nikolay Shapovalov →
Issue #3411804 by Nikolay Shapovalov: Fix phpcs Drupal.Classes,...
Status changed to Fixed 9 months ago10:33pm 5 February 2024
Comment 9 months ago →
🇨🇭Switzerland berdir Switzerland
Committed.
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix phpcs Drupal.Classes, DrupalPractice.FunctionCalls, SlevomatCodingStandard.PHP, Drupal.Semantics

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!64Fix phpcs Drupal.Classes, DrupalPractice.FunctionCalls, SlevomatCodingStandard.PHP, Drupal.Semantics
Merged

Comments & Activities

Fix phpcs Drupal.Classes, DrupalPractice.FunctionCalls, SlevomatCodingStandard.PHP, Drupal.Semantics

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!64Fix phpcs Drupal.Classes, DrupalPractice.FunctionCalls, SlevomatCodingStandard.PHP, Drupal.SemanticsMerged

Comments & Activities

!64Fix phpcs Drupal.Classes, DrupalPractice.FunctionCalls, SlevomatCodingStandard.PHP, Drupal.Semantics
Merged