- Issue created by @heddn
- Merge request !123Resolve #3411381 "Since symfony/dependency injection 6.4 is deprecated" → (Merged) created by heddn
- Status changed to Needs review
over 1 year ago 4:00pm 29 December 2023 - Status changed to Needs work
7 months ago 12:09pm 13 September 2024 - 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
Injecting the full container like that is a bad practice, let's see if we can use a service collector instead.
- Status changed to Needs review
7 months ago 12:40pm 13 September 2024 - 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
Moved to a locator and automatically flagged all handlers as non-shared. Will then see if we can make them private.
- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
Okay that seemed to work, now let's try making all handlers private.
- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
Yeah that didn't work out well, screw it. We got a service locator and some DX QOL by no longer having to set the shared flag, that's good enough.
- Status changed to Fixed
7 months ago 3:31pm 13 September 2024 -
kristiaanvandeneynde →
committed 7b9a3853 on 3.3.x authored by
heddn →
Issue #3411381 by kristiaanvandeneynde, heddn: Since symfony/dependency-...
-
kristiaanvandeneynde →
committed 7b9a3853 on 3.3.x authored by
heddn →
-
kristiaanvandeneynde →
committed dba9dbed on 2.3.x authored by
heddn →
Issue #3411381 by kristiaanvandeneynde, heddn: Since symfony/dependency-...
-
kristiaanvandeneynde →
committed dba9dbed on 2.3.x authored by
heddn →
Automatically closed - issue fixed for 2 weeks with no activity.