- Issue created by @hadiseh
- Issue was unassigned.
- 🇬🇧United Kingdom aaron.ferris
This is indeed in as a todo, if im looking at the right place...
/** * {@inheritdoc} * * Send SMS using 'smsframework' module. */ public function sendSecretToIdentity(string $identity, string $secret): bool { $sms = new SmsMessage(); $sms->setMessage($secret); // TODO: make sms text configurable.
- Assigned to aaron.ferris
- Merge request !2Issue #3411206: initial run at adding a configurable message → (Closed) created by aaron.ferris
- Status changed to Needs work
10 months ago 4:38pm 11 May 2024 - 🇬🇧United Kingdom aaron.ferris
Added the initial multi lingual bits for this, what's proving to be a problem is how this field is validated, which is via AJAX
otp_field.check_secret: path: /opt_field/check_secret defaults: _controller: 'Drupal\otp_field\Controller\CheckSecretController:checkSecret' methods: ['POST'] requirements: _permission: access content options: no_cache: true
Which means when the button is pressed, the validation fires but without a language prefix so the config is always in the default site language (no prefix) - needs more work to get around this.
-
hejazee →
committed 49e80f14 on 1.0.x
Issue #3411206 by aaron.ferris, hejazee: OTP Field SMS: Make SMS text...
-
hejazee →
committed 49e80f14 on 1.0.x
- Assigned to hejazee
- Status changed to Fixed
10 months ago 9:21pm 12 May 2024 - Status changed to Needs work
10 months ago 9:28pm 12 May 2024 Thanks to @aaron.ferris,
I have slightly changed your work and committed.Some issues still exist, including Multilingual support and update hooks.
I'm working to fix them...hejazee → changed the visibility of the branch 3411206-sms-text to hidden.
-
hejazee →
committed e1a2d113 on 1.0.x
Issue #3411206 by aaron.ferris, hejazee: Added an update hook for...
-
hejazee →
committed e1a2d113 on 1.0.x
I have added an update hook for setting the default value for sms text.
-
hejazee →
committed 3d7da50e on 1.0.x
Issue #3411206 by aaron.ferris, hejazee: make the ajax endpoint URL...
-
hejazee →
committed 3d7da50e on 1.0.x
- Status changed to Fixed
10 months ago 10:05pm 12 May 2024 I have fixed the ajax endpoint URL. Multilingual request is now possible.
Automatically closed - issue fixed for 2 weeks with no activity.