- Issue created by @Ryo Yamashita
- Merge request !2201Fix an issue of OpenStack image in SPA forms (drupal/cloud_dashboard) β (Merged) created by Ryo Yamashita
- Open on Drupal.org βCore: 10.1.4 + Environment: PHP 8.2 & MySQL 8last update
11 months ago Waiting for branch to pass - Status changed to Needs review
11 months ago 7:28am 28 December 2023 - Status changed to Needs work
11 months ago 9:11pm 28 December 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the fix. I posted my comments. Thanks
- last update
11 months ago 358 pass, 3 fail - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Also, please refactor the following method like https://chat.openai.com/share/b2ee03d3-7bc9-4849-bba1-689db51b8afb:
public function deleteProcess(CloudContentEntityBase $entity, callable $process_cloud_resouce, callable $process_entity): bool { try { $this->cloudConfigPluginManager->setCloudContext($entity->getCloudContext()); $cloud_config = $this->cloudConfigPluginManager->loadConfigEntity(); if ($cloud_config->isRemote()) { $process_cloud_resouce($entity); $this->processOperationStatus($entity, 'deleted remotely'); return TRUE; } if (!$process_cloud_resouce($entity)) { $this->processOperationErrorStatus($entity, 'deleted'); return FALSE; } $process_entity($entity); $this->processOperationStatus($entity, 'deleted'); return TRUE; } catch (\Exception $e) { $this->handleException($e); return FALSE; // Exception handling: return FALSE indicating failure. } }
- last update
11 months ago 358 pass, 3 fail - last update
11 months ago 358 pass, 3 fail - Open on Drupal.org βCore: 10.1.4 + Environment: PHP 8.2 & MySQL 8last update
11 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 1:58am 9 January 2024 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the update. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - Status changed to RTBC
10 months ago 5:53am 10 January 2024 -
yas β
committed aba2d272 on 6.x authored by
Ryo Yamashita β
Issue #3411129 by Ryo Yamashita, yas: Fix an issue of OpenStack image in...
-
yas β
committed aba2d272 on 6.x authored by
Ryo Yamashita β
-
yas β
committed b89f4375 on 5.x authored by
Ryo Yamashita β
Issue #3411129 by Ryo Yamashita, yas: Fix an issue of OpenStack image in...
-
yas β
committed b89f4375 on 5.x authored by
Ryo Yamashita β
- Status changed to Fixed
10 months ago 5:54am 10 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.