- Issue created by @ahmad aziz
- 🇵🇰Pakistan ahmad aziz
Ahmad Aziz → changed the visibility of the branch 3410847-replace-readme.txt-with to hidden.
- Issue was unassigned.
- Status changed to Needs review
11 months ago 7:37am 26 December 2023 - Status changed to RTBC
11 months ago 7:43am 26 December 2023 - First commit to issue fork.
-
VladimirAus →
committed 6e2f6c8c on 8.x-1.x authored by
Ahmad Aziz →
Issue #3410847: Replace README.txt with README.md
-
VladimirAus →
committed 6e2f6c8c on 8.x-1.x authored by
Ahmad Aziz →
- Status changed to Fixed
3 months ago 3:54pm 7 August 2024 - Status changed to Needs work
3 months ago 10:08pm 7 August 2024 - 🇩🇪Germany zany
There are now two readme files in the packaged zip:
unzip -l editor_advanced_link-2.2.5.zip |rg -i readme 2269 08-07-2024 17:55 editor_advanced_link/README.md 1942 08-07-2024 17:55 editor_advanced_link/readme.md
This will be a major problem for case-insensitve filesystems (Windows, macOS).
Composer may break with
Update of drupal/editor_advanced_link failed 5/5 [============================] 100% In ZipDownloader.php line 172: Failed to extract drupal/editor_advanced_link: (1) '/usr/bin/unzip' -qq 'vendor/composer/tmp-xyz.zip' -d 'vendor/composer/xyz' replace vendor/composer/xyz/editor_advanced_link/readme.md? [y]es, [n]o, [A]ll, [N]one, [r]ename: NULL (EOF or read error, treating as "[N]one" ...)
- 🇬🇧United Kingdom SirClickALot Somerset
I can confirm that the duplicate file / case-sensitivity issue has cause a failure to update on my system too.
Drupal 10.3.1 Apache/2.4.33 (Win64) OpenSSL/1.0.2u mod_fcgid/2.3.9 PHP/8.3.1 PHP 8.3.7, memory limit: 256M MySQL 5.7.24 PHP Caching module: OpCache Web browser: Version 127.0.6533.89 (Official Build) (64-bit)
- 🇬🇧United Kingdom james.williams
This can make working with the repo really hard; to the point of blocking contribution! Such a shame that a relatively low-value contribution like this can cause high-impact problems :( There was already a README.md in the repo, I'm not sure why this issue was even opened, let alone alone committed?
- 🇦🇺Australia VladimirAus Brisbane, Australia
Sound like an issue with serious consequences.
- Status changed to Fixed
3 months ago 5:54am 9 August 2024 -
VladimirAus →
committed 94d3b78c on 2.2.x
Issue #3410847 by Ahmad Aziz, VladimirAus, SirClickalot, zany: Replace...
-
VladimirAus →
committed 94d3b78c on 2.2.x
- 🇦🇺Australia VladimirAus Brisbane, Australia
Fixed in 2.2.6 →
Thanks everyone 🍻 Automatically closed - issue fixed for 2 weeks with no activity.