Allow commit-code-check.sh to skip non-PHP checks with new opt-in flag

Created on 22 December 2023, 6 months ago
Updated 21 April 2024, 2 months ago

Problem/Motivation

Core ships a commit-code-check.sh script to help with pre-commit linting ahead of changes to Drupal core. It tries to run cspell, which requires yarn. I don't want to have to install yarn globally, and there is a trend toward container-based development where dev tooling isn't always comingled with the PHP runtime or the developer's "base" system. We should allow this script to run what it can, since everything else it does only depends on git and PHP.

Steps to reproduce

Run the script without yarn installed, it will fail.

Proposed resolution

Allow the check that requires yarn to gracefully fail with a notice if you specify the new --skipjs flag.

Remaining tasks

Do it.

User interface changes

API changes

Data model changes

Release notes snippet

Dev tooling only change. I don't believe this is used at all in CI so there shouldn't be major issues rolling this out. A CR can explain the new flag.

πŸ“Œ Task
Status

Closed: duplicate

Version

11.0 πŸ”₯

Component
OtherΒ  β†’

Last updated about 3 hours ago

Created by

πŸ‡ΊπŸ‡ΈUnited States bradjones1 Digital Nomad Life

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024