Created on 22 December 2023, 6 months ago
Updated 22 January 2024, 5 months ago

Problem/Motivation

 ------ ---------------------------------------------------------------------- 
  Line   ldap_servers/src/ServerListBuilder.php                                
 ------ ---------------------------------------------------------------------- 
  88     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 

Steps to reproduce

Proposed resolution

The ServerListBuilder needs a corresponding View. A view plugin is also needed for the status of the LDAP server.

Remaining tasks

  • Create View
  • Create Server Status View plugin

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

🇺🇸United States bluegeek9

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @bluegeek9
  • First commit to issue fork.
  • Status changed to Needs review 6 months ago
  • 🇮🇳India viren18febS

    Hi, i have fixed the issues and added a patch for this
    Thanks

  • Status changed to Needs work 6 months ago
  • 🇺🇸United States bluegeek9
    TypeError: Drupal\ldap_servers\ServerListBuilder::__construct(): Argument #1 ($ldapBridge) must be of type Drupal\ldap_servers\LdapBridge, Drupal\Core\Config\Entity\ConfigEntityType given, called in C:\inetpub\wwwroot\web\core\lib\Drupal\Core\Entity\EntityListBuilder.php on line 59 in Drupal\ldap_servers\ServerListBuilder->__construct() (line 33 of modules\contrib\ldap\ldap_servers\src\ServerListBuilder.php).
    
    Drupal\Core\Entity\EntityListBuilder::createInstance() (Line: 269)
    Drupal\Core\Entity\EntityTypeManager->createHandlerInstance() (Line: 258)
    Drupal\Core\Entity\EntityTypeManager->getHandler() (Line: 199)
    Drupal\Core\Entity\EntityTypeManager->getListBuilder() (Line: 23)
    Drupal\Core\Entity\Controller\EntityListController->listing()
    call_user_func_array() (Line: 123)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 592)
    Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 124)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
    Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
    Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 58)
    Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
    Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 106)
    Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
    Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
    Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
    Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 51)
    Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 704)
    Drupal\Core\DrupalKernel->handle() (Line: 19)
    
  • Status changed to Fixed 6 months ago
  • 🇺🇸United States bluegeek9
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024