Webforms are missing metatags property of api response

I've lessened the condition for metatags links generation. Check PR.

I'm also adding a patch file.

This solution works for me, but I've just figured it out that it only adds webform translations if content_translation module is installed which is not optimal. https://git.drupalcode.org/project/lupus_ce_renderer/-/merge_requests/33...

This condition might need some more consideration.

> if (array_diff(['hasLinkTemplate', 'getTranslationLanguages'], get_class_methods($entity)) &&

This should check for the dedicated interface we need. each method should be provided by a suiting more narrow interface, content-entity-interface is a collection of those. Let's checked for the specific ones with an OR statement so this is a) nicer and b) easier to follow

> This solution works for me, but I've just figured it out that it only adds webform translations if content_translation module is installed which is not optimal. https://git.drupalcode.org/project/lupus_ce_renderer/-/merge_requests/33...

This is not really nice, indeed, but I think good enough. In practice only people having that module installed will want to have these metatags, so let's just keep doing it that way.

Alternatively we could use:

if (($entity instanceof ContentEntityInterface || $entity instanceof WebformInterface) &&
        $entity->hasLinkTemplate('canonical') &&
        // Only add alternate link if entity is translated.
        count($entity->getTranslationLanguages()) > 1) {

but I don't like this solution either. getTranslationLanguages is defined on WebformInterface and the problem with this is that it is too specific for my taste. It might cause issues if webform is not installed.

ContentEntityInterface (ultimately) inherits the method from web/core/lib/Drupal/Core/TypedData/TranslatableInterface.php but that is not the case for Config entities.

Could we do something like

if (($entity instanceof ContentEntityInterface ||
(class_exists(WebformInterface) && $entity instanceof WebformInterface))

? so we keep the check clean on interfaces, but still do work fine if webform module is not there. It also better documents why we are doing this. (webform)

I've implemented the last comment.

I've created the new patch.

merged

Automatically closed - issue fixed for 2 weeks with no activity.