- Issue created by @tstermitz
Great work Tom, seems like it still needs a bit of a cleanup, that aside, not sure if we should ship with a SCSS file, but rather use Bootstrap classes and the style that Bootstrap does it: https://getbootstrap.com/docs/5.3/components/carousel/
I've been working on a Carousel component for the 6.x version, I can share it soon and we can work together to possibly merge your work and backport the 6.x into 5.x
Could you possibly provide a MR after some cleanups? thanks
- Status changed to Needs work
11 months ago 8:17am 23 December 2023 - πΊπΈUnited States tstermitz Colorado
Thanks Sohail. I'm pretty good with SCSS, but don't claim to be a good twig programmer.
Also, although I maintain my own websites with git, I confess I've never sent a merge request to Drupal... maybe you could pm me or help educate me on that.
I pulled the carousel.scss file out to my own styles as you suggested. The BS default white makes it impossible to see the indicators and arrows, so most people will need their own colors and styles
I cleaned up the view-carousel.twig file a little taking out the debugging code. I don't know all the Drupal coding standards so I'd appreciate any other suggestions. The Aria stuff gets pretty complicated to do correctly; or else just leave it as Bootstrap defaults.
I did forget to mention how the Views Carousel gets invoked.... It needs a template over-ride file which merely imports the component:
File: templates/views/views-view-unformatted--carousel.html.twig Contents: {% include "@tangodxrdx/carousel/view-carousel.twig" %}
Here's the carousel code:
<div id="carousel--{{ view.storage.id }}-{{ view.current_display }}" class="carousel slide" data-bs-ride="carousel" data-bs-wrap="true"> <div class="carousel-indicators"> {% for item in rows %} <button type="button" data-bs-target="#carousel--{{ view.storage.id }}-{{ view.current_display }}" data-bs-slide-to="{{ loop.index-1 }}" aria-label="arialabel-{{ item.content['#node'].label }}" {{ loop.first ? 'class="active"'}} {{ loop.first ? 'aria-current="true"' }}> </button> {% endfor %} </div> <div class="carousel-inner"> {% for item in rows %} <div class="carousel-item {{ loop.first ? 'active' }} carousel--{{ view.storage.id }}-{{ view.current_display }}" data-bs-interval="5000" > {% block views_row %} {{ item.content }} {% endblock %} </div> {% endfor %} </div> <button class="carousel-control-prev" type="button" data-bs-target="#carousel--{{ view.storage.id }}-{{ view.current_display }}" data-bs-slide="prev" style="cursor:pointer"> <span class="carousel-control-prev-icon"></span> </button> <button class="carousel-control-next" type="button" data-bs-target="#carousel--{{ view.storage.id }}-{{ view.current_display }}" data-bs-slide="next" style="cursor:pointer"> <span class="carousel-control-next-icon"></span> </button> </div>
- πΊπΈUnited States amstercad
I'm willing to help you, but I can't go ahead and learn 5.x code, (with Components, uggh, ...too old skool.), because I'm so focused on 6.x with SDC. SDC is the future.
I cannot imagine my answer is immediately useful for you, however if you can get to Radix 6.x (ultra-special SDC Edition) I think I can be more helpful for you. For what it is worth, SDC is the future of Drupal front end theming, so go for it. If you want to ask why, I'll try to give you an answer, but until then, https://idiazroncero.com/en/certainties/component-based-design-using-sin...
- πΊπΈUnited States tstermitz Colorado
Thanks Amstercad. Your article is very interesting and explains the situation well.
I guess my Radix 5 issue is useful as documentation or an example of how to do a carousel with views. It probably isn't necessary to add it to the Radix theme.
- Status changed to Closed: outdated
5 months ago 11:25am 21 June 2024 No longer supported/outdated, closing - feel free to open a MR if applicable.
This is done in Radix 6.x though.