- Issue created by @berdir
- last update
12 months ago Build Successful - last update
12 months ago Build Successful - Status changed to Needs review
12 months ago 3:17pm 21 December 2023 - 🇨🇭Switzerland berdir Switzerland
Introduced a method on the trait used it on all events where it makes sense, only exception is commerce_view_item_list, which calls it item but it's a product variation.
Also added an event and a test that verifies it works.
MR needs work on docs and trait doesn't use DI, that's a bit awkward as every plugin class would need to do the whole DI dance, probably even with BC?
- last update
12 months ago Build Successful - 🇨🇭Switzerland berdir Switzerland
Fixed a missing use. Not sure why it's still a Build Successful and not a pass, https://dispatcher.drupalci.org/job/drupal_contrib/724221/console seems OK to me.
- last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - 🇨🇭Switzerland berdir Switzerland
I pushed a few updates. I didn't realize that $item is sometimes an order item and sometimes it's actually a product variation. The naming really doesn't help there.
So there are now two methods on the trait and two events. Still would like some first feedback before finishing this up with comments and so on.
- last update
12 months ago Build Successful - last update
11 months ago Build Successful - 🇺🇸United States japerry KVUO
On first glance this looks great! Waiting to see if I can get the new test suite to pass, I committed some changes a week ago that fixed tests for Drupal 10.
- 🇺🇸United States rszrama
Tagging and cross-referencing ✨ Add alter event processing to collector Active as one or the other (or both?) of these approaches will be needed. A more general solution for altering event data seems to make sense, though ... for example, determining what coupon code should be present on a purchase event when multiple coupon codes have been applied to an order.
- First commit to issue fork.