- Issue created by @zanvidmar
- Status changed to Needs review
11 months ago 11:48am 20 December 2023 - last update
11 months ago 146 pass, 1 fail The last submitted patch, 4: 3409973-properly-check-revert-access-2.diff, failed testing. View results →
- last update
10 months ago 146 pass, 1 fail - 🇺🇸United States recrit
The
\Drupal\entity\Controller\RevisionControllerTrait::hasRevertRevisionAccess()defines the return to be a boolean. It appears that the real bug is that\Drupal\entity\Controller\RevisionControllerController::hasRevertRevisionAccess()is incorrectly returning an AccessResult.Changes made in the attached patch:
\Drupal\entity\Controller\RevisionControllerController::hasRevertRevisionAccess(): Update to correctly return a boolean.
The last submitted patch, 7: entity-3409973-7.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs review
10 months ago 11:47pm 29 January 2024 - last update
10 months ago 149 pass - 🇺🇸United States recrit
patch entity-3409973-7.patch test results in #7 🐛 Revision operation link "Revert" is not properly checking access Needs review proves that the module is not checking the permission. The test user role did not have the permission "revert all entity_test_enhanced revisions".
the attached patch entity-3409973-9.patch updates the test so that the user role has the permission "revert all entity_test_enhanced revisions".