Contrib.social

FileUploadHandler::handleExtensionValidation() should check for empty extensions string

Open on Drupal.org →
Created on 20 December 2023, 11 months ago
Updated 2 March 2024, 9 months ago

Problem/Motivation

Currently, logic for deciding whether to remove extension validation checks:

  if (isset($validators['FileExtension'])) {
      if (!isset($validators['FileExtension']['extensions'])) {
        // If 'FileExtension' is set and the list is empty then the caller wants
        // to allow any extension. In this case we have to remove the validator
        // or else it will reject all extensions.
        unset($validators['FileExtension']);
      }
    }

However, the code comments say:

// If 'FileExtension' is set and the list is empty then the caller wants
// to allow any extension. In this case we have to remove the validator
// or else it will reject all extensions.

Either the code is wrong or the comment is wrong.

There are tests that rely on having an empty extensions list to not trigger the security rename feature later in the code.

We need to evaluate whether the test assumptions are correct.

Steps to reproduce

Proposed resolution

Change the code to check for empty instead:

  if (isset($validators['FileExtension'])) {
      if (empty($validators['FileExtension']['extensions'])) {
        // If 'FileExtension' is set and the list is empty then the caller wants
        // to allow any extension. In this case we have to remove the validator
        // or else it will reject all extensions.
        unset($validators['FileExtension']);
      }
    }

Remaining tasks

Fix test failures.

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Closed: won't fix

Version

11.0 🔥

Component
File module  →

Last updated 1 day ago

Created by

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024