- Issue created by @ankushgautam76@gmail.com
- 🇮🇳India sidharth_soman Bangalore
This patch unblocks the error for now but I'm unsure about what exactly we need to do within the custom method. Leaving it open for now for anyone else to pick up as well.
- 🇺🇸United States apmsooner
Thanks for reporting this bug. Yeah, that patch is not the fix. The setRenderCache function got removed and replaced with setVariationCache. For reference: https://git.drupalcode.org/project/drupal/-/blob/10.2.x/core/modules/jso...
I'll dig in more when i get some free time to test and provide a new release to address this.
- 🇪🇨Ecuador alexis_mc
I found a solution but I am not sure if it is the best option please help me review
- Status changed to Needs review
6 months ago 4:40pm 22 December 2023 - last update
6 months ago 1 pass - last update
6 months ago 2 fail The last submitted patch, 4: fatal_error_with_drupal_upgrade_10_2-3409683-4.patch, failed testing. View results →
- Status changed to Needs work
6 months ago 5:37pm 22 December 2023 - 🇺🇸United States apmsooner
We're gonna have to create a 2.x branch that targets this core version for this change. Tests are failing against current branch for this reason but also need to add .gitlab-ci.yml to switch testing. Let me create the 2.x branch and we can reassign this task over.
- Status changed to Needs review
6 months ago 6:29pm 22 December 2023 - 🇺🇸United States apmsooner
The pipeline passes on the 2.x branch with the patch from #4 applied. Someone please manually test out this functionality using 2.x dev branch and add review and I'll create a release. FYI, the 1.x version has now been pinned to ^10.1 to restrict this from happening.
- Status changed to Fixed
6 months ago 7:29am 28 December 2023 - 🇺🇸United States apmsooner
Tested this and works fine in dev branch. Creating a release to close this issue out.
- Status changed to Fixed
6 months ago 7:33am 28 December 2023 - 🇺🇸United States apmsooner
2.0.0 is now released to support 10.2 changes that resulted in the bug :)