- Issue created by @michaelablackham
- Status changed to Needs review
12 months ago 5:46pm 30 January 2024 - πΊπΈUnited States justin2pin
Test / review against https://git.drupalcode.org/project/mercury_editor/-/merge_requests/34
- Status changed to Needs work
12 months ago 5:54pm 2 February 2024 - πΊπΈUnited States michaelablackham
I currently hit "escape" and the modal disappears. However, I am brought back to the top of the page and not to the element that triggered the action.
The ideal functionality is to close the window and return the :focus back to the link or button that triggered the action. that way a user can continue on their tab journey without starting over.
This same action should happen when you hit the "X" (close) icon as well. Currently they both bring focus back to the top of the page.
Screencast showing me hitting "escape" and focus is brought back to top and you next tab shows "skip to main content" https://share.cleanshot.com/G7KfmR27
- Status changed to Needs review
12 months ago 9:08pm 7 February 2024 - πΊπΈUnited States justin2pin
Should be fixed in commit 1922132f of https://git.drupalcode.org/project/mercury_editor/-/merge_requests/34
- Status changed to RTBC
12 months ago 10:37pm 7 February 2024 - πΊπΈUnited States michaelablackham
It looks like this may have caused some others bugs
I can click the "close" and focus is brought back to the element that triggered it, so the mouse usage has been updated however
- I cannot hit "escape" and close it anymore
- I can use keyboard to choose content once the component modal is open
Screencast: https://share.cleanshot.com/K3MYZz53
- Status changed to Fixed
11 months ago 3:55pm 15 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.