- Issue created by @tedbow
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Right now in the conversion script the module code is converted but composer dependencies are not added. I did that step manually
This is referring to https://git.drupalcode.org/project/automatic_updates/-/blob/3.0.x/script..., right? I'm not seeing where dependencies are added there? 🤔
- Assigned to tedbow
- Status changed to Needs work
over 1 year ago 4:42pm 18 December 2023 - Merge request !997Issue #3409491 add composer dependencies in conversion script → (Merged) created by tedbow
- last update
over 1 year ago Custom Commands Failed - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Okay. The reason I'm asking: you could automate it using something like
$ jq -r '.["require-dev"]["symfony/lock"]' composer.json ^6.4
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Also: plenty of examples in the AM:A repo — grep for in https://git.drupalcode.org/project/acquia_migrate/-/blob/recommendations... for example
- last update
over 1 year ago Build Successful - last update
over 1 year ago 783 pass - last update
over 1 year ago 783 pass - Status changed to Needs review
over 1 year ago 8:45pm 18 December 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
I have tested this and correctly requires composer dependencies by checking out the 11.x versions and running the composer commands that I use to do manually. I tested against the current MR and produces the same result as far as the composer dependencies. I also had checkout the 11.x version of dictionary.txt and auto update that.
I will probably commit this myself since it only involves the conversion script which is not used by the contrib module and remove core conversion.
- last update
over 1 year ago 783 pass - Status changed to Fixed
over 1 year ago 9:32pm 18 December 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
Opening this up for a small follow-up that there is empty line at the top of core/misc/cspell/dictionary.txt and that we don't sort case insensitively when adding new words(existing issue )
- Status changed to Active
over 1 year ago 10:06pm 18 December 2023 - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 783 pass - last update
over 1 year ago 783 pass - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - Status changed to Fixed
over 1 year ago 12:26pm 19 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.