- Issue created by @tedbow
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Right now in the conversion script the module code is converted but composer dependencies are not added. I did that step manually
This is referring to https://git.drupalcode.org/project/automatic_updates/-/blob/3.0.x/script..., right? I'm not seeing where dependencies are added there? π€
- Assigned to tedbow
- Status changed to Needs work
about 1 year ago 4:42pm 18 December 2023 - Merge request !997Issue #3409491 add composer dependencies in conversion script β (Merged) created by tedbow
- last update
about 1 year ago Custom Commands Failed - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Okay. The reason I'm asking: you could automate it using something like
$ jq -r '.["require-dev"]["symfony/lock"]' composer.json ^6.4
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Also: plenty of examples in the AM:A repo β grep for in https://git.drupalcode.org/project/acquia_migrate/-/blob/recommendations... for example
- last update
about 1 year ago Build Successful - last update
about 1 year ago 783 pass - last update
about 1 year ago 783 pass - Status changed to Needs review
about 1 year ago 8:45pm 18 December 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
I have tested this and correctly requires composer dependencies by checking out the 11.x versions and running the composer commands that I use to do manually. I tested against the current MR and produces the same result as far as the composer dependencies. I also had checkout the 11.x version of dictionary.txt and auto update that.
I will probably commit this myself since it only involves the conversion script which is not used by the contrib module and remove core conversion.
- last update
about 1 year ago 783 pass -
tedbow β
committed 2d8b2289 on 3.0.x
Issue #3409491: Add handling of the Composer dependencies to the...
-
tedbow β
committed 2d8b2289 on 3.0.x
- Status changed to Fixed
about 1 year ago 9:32pm 18 December 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Opening this up for a small follow-up that there is empty line at the top of core/misc/cspell/dictionary.txt and that we don't sort case insensitively when adding new words(existing issue )
- Status changed to Active
about 1 year ago 10:06pm 18 December 2023 - Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago 783 pass - last update
about 1 year ago 783 pass -
tedbow β
committed 9405be2e on 3.0.x
Issue #3409491 by tedbow: Add handling of the Composer dependencies to...
-
tedbow β
committed 9405be2e on 3.0.x
- Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed -
tedbow β
committed 80514f0d on 3.0.x
Issue #3409491 by tedbow: Add handling of the Composer dependencies to...
-
tedbow β
committed 80514f0d on 3.0.x
- Status changed to Fixed
about 1 year ago 12:26pm 19 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.